Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 05:31:27PM +0300, Marcel Apfelbaum wrote: > > > On Monday, October 12, 2015, Michael S. Tsirkin wrote: > > On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > > The virtio devices are converted to PCI-Express > > if they are plugged into a PCI

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Marcel Apfelbaum
On Monday, October 12, 2015, Michael S. Tsirkin wrote: > On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > > The virtio devices are converted to PCI-Express > > if they are plugged into a PCI-Express bus and > > the 'modern' protocol is enabled. > > > > Signed-off-by: Marcel Apf

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Cao jin
Hi, Michael Thanks for your quick response:) On 10/13/2015 04:48 PM, Michael S. Tsirkin wrote: On Tue, Oct 13, 2015 at 04:41:35PM +0800, Cao jin wrote: In case user regret when hot-adding multi-function, should roll back, device_del the function added but not exposed to the guest. Signed-o

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 04:41:35PM +0800, Cao jin wrote: > In case user regret when hot-adding multi-function, should roll back, > device_del the function added but not exposed to the guest. > > Signed-off-by: Cao jin > --- > hw/pci/pci_host.c | 6 +- > hw/pci/pcie.c | 22 ++

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 10:13:37AM +0200, Gerd Hoffmann wrote: > On Mo, 2015-10-12 at 18:42 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > > > The virtio devices are converted to PCI-Express > > > if they are plugged into a PCI-Express bus a

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-13 Thread Gerd Hoffmann
On Mo, 2015-10-12 at 18:42 +0300, Michael S. Tsirkin wrote: > On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > > The virtio devices are converted to PCI-Express > > if they are plugged into a PCI-Express bus and > > the 'modern' protocol is enabled. > > > > Signed-off-by: Marcel

Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-12 Thread Michael S. Tsirkin
On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > The virtio devices are converted to PCI-Express > if they are plugged into a PCI-Express bus and > the 'modern' protocol is enabled. > > Signed-off-by: Marcel Apfelbaum > --- > > This is an RFC because all it does it adds the PC

[Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices

2015-10-12 Thread Marcel Apfelbaum
The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Signed-off-by: Marcel Apfelbaum --- This is an RFC because all it does it adds the PCIe capability and nothing more. I post it early so I can get feedbacks on what is