Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-10-04 Thread Kevin Wolf
Am 04.10.2017 um 14:23 hat Manos Pitsidianakis geschrieben: > > > diff --git a/block.c b/block.c > > > index 81bd51b670..f874aabbfb 100644 > > > --- a/block.c > > > +++ b/block.c > > > +/* insert 'node' as child bs of 'parent' node */ > > > +if (check_node_edge(parent, child, errp)) { > > >

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-10-04 Thread Manos Pitsidianakis
On Fri, Sep 29, 2017 at 07:52:35PM +0200, Kevin Wolf wrote: Am 15.08.2017 um 09:45 hat Manos Pitsidianakis geschrieben: block-insert-node and its pair command block-remove-node provide runtime insertion and removal of filter nodes. block-insert-node takes a (parent, child) and (node, child) pai

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-16 Thread Eric Blake
On 08/16/2017 07:11 AM, Manos Pitsidianakis wrote: >> >> Given a qcow2 image backing chain: >> >> base <- active >> >> there are four BDS (2 format, 2 protocol). Ideally, I could add >> filtering to any one of those four nodes (a filter on the base protocol >> level restricts how much guest data

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-16 Thread Manos Pitsidianakis
On Wed, Aug 16, 2017 at 06:59:25AM -0500, Eric Blake wrote: On 08/16/2017 04:41 AM, Manos Pitsidianakis wrote: +## +# @block-insert-node: +# +# Insert a filter node between a specific edge in the block driver state graph. +# @parent: the name of the parent node or device +# @node:the name

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-16 Thread Eric Blake
On 08/16/2017 04:41 AM, Manos Pitsidianakis wrote: >>> +## >>> +# @block-insert-node: >>> +# >>> +# Insert a filter node between a specific edge in the block driver >>> state graph. >>> +# @parent: the name of the parent node or device >>> +# @node:the name of the node to insert under parent

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-16 Thread Manos Pitsidianakis
On Tue, Aug 15, 2017 at 05:12:42PM -0500, Eric Blake wrote: On 08/15/2017 02:45 AM, Manos Pitsidianakis wrote: block-insert-node and its pair command block-remove-node provide runtime insertion and removal of filter nodes. block-insert-node takes a (parent, child) and (node, child) pair of edge

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-15 Thread Eric Blake
On 08/15/2017 02:45 AM, Manos Pitsidianakis wrote: > block-insert-node and its pair command block-remove-node provide runtime > insertion and removal of filter nodes. > > block-insert-node takes a (parent, child) and (node, child) pair of > edges and unrefs the (parent, child) BdrvChild relationsh

[Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-15 Thread Manos Pitsidianakis
block-insert-node and its pair command block-remove-node provide runtime insertion and removal of filter nodes. block-insert-node takes a (parent, child) and (node, child) pair of edges and unrefs the (parent, child) BdrvChild relationship and creates a new (parent, node) child with the same BdrvC