Re: [Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

2015-12-01 Thread Vasiliy Tolstov
2015-12-02 8:23 GMT+03:00 Hitoshi Mitake : > Seems that your patch violates the coding style of qemu. You can check the > style with scripts/checkpatch.pl. > > > Comment outed code isn't good. You should remove it (in addition, it > wouldn't be required). Thanks! -- Vasiliy Tolstov, e-mail: v.t

Re: [Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

2015-12-01 Thread Hitoshi Mitake
On Wed, Dec 2, 2015 at 1:12 AM, Vasiliy Tolstov wrote: > Signed-off-by: Vasiliy Tolstov > --- > block/sheepdog.c | 59 > ++-- > 1 file changed, 57 insertions(+), 2 deletions(-) > Seems that your patch violates the coding style of qemu. You ca

[Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

2015-12-01 Thread Vasiliy Tolstov
This is first try to get ability to remove snapshot from sheepdog, I'm stuck ad the simple thing: sheepdog does not allow to remove snapshot with objects with message: ERROR [deletion] delete_vdi_work(1811) vid: X still has objects I'm check dog/vdi.c code and see, that in case of deletion vdi

[Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

2015-12-01 Thread Vasiliy Tolstov
Signed-off-by: Vasiliy Tolstov --- block/sheepdog.c | 59 ++-- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index d80e4ed..c3fae50 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -248