Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-22 Thread Eduardo Habkost
On Mon, Sep 11, 2017 at 01:51:54PM +0200, Paolo Bonzini wrote: > On 07/09/2017 10:11, Kevin Wolf wrote: > > Am 06.09.2017 um 13:29 hat Cornelia Huck geschrieben: > >> On Wed, 6 Sep 2017 11:49:27 +0200 > >> Cornelia Huck wrote: > >> > >>> configure_accelerator() falls back to tcg if no accelerator

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-11 Thread Paolo Bonzini
On 11/09/2017 13:51, Cornelia Huck wrote: > On Mon, 11 Sep 2017 13:48:46 +0200 > Paolo Bonzini wrote: > >> On 06/09/2017 16:35, Peter Maydell wrote: > accel = qemu_opt_get(qemu_get_machine_opts(), "accel"); > if (accel == NULL) { > -/* Use the default "accelerator",

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-11 Thread Cornelia Huck
On Mon, 11 Sep 2017 13:48:46 +0200 Paolo Bonzini wrote: > On 06/09/2017 16:35, Peter Maydell wrote: > >>> accel = qemu_opt_get(qemu_get_machine_opts(), "accel"); > >>> if (accel == NULL) { > >>> -/* Use the default "accelerator", tcg */ > >>> -accel = "tcg"; > >>> +

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-11 Thread Paolo Bonzini
On 07/09/2017 10:11, Kevin Wolf wrote: > Am 06.09.2017 um 13:29 hat Cornelia Huck geschrieben: >> On Wed, 6 Sep 2017 11:49:27 +0200 >> Cornelia Huck wrote: >> >>> configure_accelerator() falls back to tcg if no accelerator has >>> been specified. Formerly, we could be sure that tcg is always >>>

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-11 Thread Paolo Bonzini
On 06/09/2017 16:35, Peter Maydell wrote: >>> accel = qemu_opt_get(qemu_get_machine_opts(), "accel"); >>> if (accel == NULL) { >>> -/* Use the default "accelerator", tcg */ >>> -accel = "tcg"; >>> +accel = default_accelerator(); >> It actually may be easier to just

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-07 Thread Kevin Wolf
Am 07.09.2017 um 10:25 hat Cornelia Huck geschrieben: > On Thu, 7 Sep 2017 10:14:27 +0200 > Thomas Huth wrote: > > > On 07.09.2017 10:11, Kevin Wolf wrote: > > [...] > > > But the real reason why I'm replying: Should we add changing the default > > > to "kvm:tcg" to the list of planned 3.0 change

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-07 Thread Cornelia Huck
On Thu, 7 Sep 2017 10:14:27 +0200 Thomas Huth wrote: > On 07.09.2017 10:11, Kevin Wolf wrote: > [...] > > But the real reason why I'm replying: Should we add changing the default > > to "kvm:tcg" to the list of planned 3.0 changes? I am part of the group > > that intentionally uses TCG occasional

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-07 Thread Thomas Huth
On 07.09.2017 10:11, Kevin Wolf wrote: [...] > But the real reason why I'm replying: Should we add changing the default > to "kvm:tcg" to the list of planned 3.0 changes? I am part of the group > that intentionally uses TCG occasionally, but I think the majority of > users wants to use KVM (or what

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-07 Thread Kevin Wolf
Am 06.09.2017 um 13:29 hat Cornelia Huck geschrieben: > On Wed, 6 Sep 2017 11:49:27 +0200 > Cornelia Huck wrote: > > > configure_accelerator() falls back to tcg if no accelerator has > > been specified. Formerly, we could be sure that tcg is always > > available; however, with --disable-tcg, thi

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-06 Thread Cornelia Huck
On Wed, 6 Sep 2017 15:35:16 +0100 Peter Maydell wrote: > On 6 September 2017 at 12:29, Cornelia Huck wrote: > > On Wed, 6 Sep 2017 11:49:27 +0200 > > Cornelia Huck wrote: > >> @@ -79,8 +98,7 @@ void configure_accelerator(MachineState *ms) > >> > >> accel = qemu_opt_get(qemu_get_machine_

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-06 Thread Peter Maydell
On 6 September 2017 at 12:29, Cornelia Huck wrote: > On Wed, 6 Sep 2017 11:49:27 +0200 > Cornelia Huck wrote: >> @@ -79,8 +98,7 @@ void configure_accelerator(MachineState *ms) >> >> accel = qemu_opt_get(qemu_get_machine_opts(), "accel"); >> if (accel == NULL) { >> -/* Use the d

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-06 Thread Richard Henderson
On 09/06/2017 02:49 AM, Cornelia Huck wrote: > +/* configure makes sure we have at least one accelerator */ > +g_assert(false); > +return ""; g_assert_not_reached(); Though I do like the follow-up idea of "t:k:x:h". r~

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-06 Thread Cornelia Huck
On Wed, 6 Sep 2017 11:49:27 +0200 Cornelia Huck wrote: > configure_accelerator() falls back to tcg if no accelerator has > been specified. Formerly, we could be sure that tcg is always > available; however, with --disable-tcg, this is not longer true, > and you are not able to start qemu without

[Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-06 Thread Cornelia Huck
configure_accelerator() falls back to tcg if no accelerator has been specified. Formerly, we could be sure that tcg is always available; however, with --disable-tcg, this is not longer true, and you are not able to start qemu without explicitly specifying another accelerator on those builds. Inste