Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties

2013-02-22 Thread Eduardo Habkost
On Fri, Feb 22, 2013 at 07:17:52AM +0100, Igor Mammedov wrote: [...] > > > > Or, maybe we shouldn't even add a "kvmclock" property at all, and > > translate the legacy "kvmclock" flag to kvmclock1|kvmclock2 inside > > parse_featurestr()? > That's what I was proposing a while back. Lets do it this

Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties

2013-02-21 Thread Igor Mammedov
On Tue, 19 Feb 2013 16:03:04 -0300 Eduardo Habkost wrote: > On Mon, Feb 11, 2013 at 05:35:11PM +0100, Igor Mammedov wrote: > > * Define static properties for cpuid feature bits > > * property names of CPUID features are changed to have "f-" prefix, > > so that it would be easy to disti

Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties

2013-02-19 Thread Eduardo Habkost
On Mon, Feb 11, 2013 at 05:35:11PM +0100, Igor Mammedov wrote: > * Define static properties for cpuid feature bits > * property names of CPUID features are changed to have "f-" prefix, > so that it would be easy to distinguish them from other properties. > > * Convert [+-]cpuid_feature

[Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties

2013-02-11 Thread Igor Mammedov
* Define static properties for cpuid feature bits * property names of CPUID features are changed to have "f-" prefix, so that it would be easy to distinguish them from other properties. * Convert [+-]cpuid_features to a set(QDict) of key, value pairs, where +feat => (f-feat, on)