Re: [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue

2016-05-27 Thread Stefan Hajnoczi
On Sat, May 21, 2016 at 05:37:27PM +0200, Paolo Bonzini wrote: > > > On 21/05/2016 01:40, Stefan Hajnoczi wrote: > > while (req) { > > qemu_put_sbyte(f, 1); > > Could you just put an extra 32-bit queue id here if num_queues > 1? A > guest with num_queues > 1 cannot be started on p

Re: [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue

2016-05-21 Thread Paolo Bonzini
On 21/05/2016 01:40, Stefan Hajnoczi wrote: > while (req) { > qemu_put_sbyte(f, 1); Could you just put an extra 32-bit queue id here if num_queues > 1? A guest with num_queues > 1 cannot be started on pre-2.7 QEMU, so you can change the migration format (if virtio were using vmsta

[Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue

2016-05-20 Thread Stefan Hajnoczi
Each request in s->rq belongs to a virtqueue. When multiqueue is enabled we can no longer default to the first virtqueue. Explicitly migrate virtqueue indices when needed. The migration stream looks like this: [s->rq][mq_rq_indices, ~QEMU_VM_SUBSECTION][virtio subsections] This patch adds th