Re: [Qemu-devel] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm

2019-05-06 Thread David Gibson
On Tue, May 07, 2019 at 10:48:09AM +1000, Anton Blanchard wrote: > We should only look at 5 bits of each byte, not 6. > > Fixes: 3e00884f4e9f ("target-ppc: add vrldnmi and vrlwmi instructions") > Signed-off-by: Anton Blanchard Hrm. So, what lives in those extra bits in the 'w' instructions? Is

[Qemu-devel] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm

2019-05-06 Thread Anton Blanchard
We should only look at 5 bits of each byte, not 6. Fixes: 3e00884f4e9f ("target-ppc: add vrldnmi and vrlwmi instructions") Signed-off-by: Anton Blanchard --- target/ppc/int_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/ppc/int_helper.c b/tar