Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 10:27:51AM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >Having a named "exception" instead of an error code is fine, but I think > >it is overkill to include fully-structured data fields like 'errno' instead > >of just a string. The libvirt application API ha

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Anthony Liguori
Daniel P. Berrange wrote: Having a named "exception" instead of an error code is fine, but I think it is overkill to include fully-structured data fields like 'errno' instead of just a string. The libvirt application API has a insanely detailed error object allowing for passing of structured dat

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 09:00:33AM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >hink just returning error codes to the client is far too little > >information. I don't think we need the fully normalized structure > >that Luiz originally proposed with bus/dev addresses split out, but

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Anthony Liguori
Daniel P. Berrange wrote: hink just returning error codes to the client is far too little information. I don't think we need the fully normalized structure that Luiz originally proposed with bus/dev addresses split out, but we certainly need to include a string description giving as much detail a

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 12:40:08PM +0200, Gerd Hoffmann wrote: > >I think just returning error codes to the client is far too little > >information. I don't think we need the fully normalized structure > >that Luiz originally proposed with bus/dev addresses split out, but > >we certainly need to in

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Gerd Hoffmann
I think just returning error codes to the client is far too little information. I don't think we need the fully normalized structure that Luiz originally proposed with bus/dev addresses split out, but we certainly need to include a string description giving as much detail as possible. If attachin

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Wed, Oct 14, 2009 at 12:34:21AM +0200, Markus Armbruster wrote: > Luiz Capitulino writes: > > > Signed-off-by: Luiz Capitulino > > --- > > hw/qdev.c |4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/qdev.c b/hw/qdev.c > > index 906e897..3ce48f7 100644