Re: [Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values

2014-12-09 Thread Igor Mammedov
On Mon, 8 Dec 2014 22:54:03 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 08, 2014 at 04:08:06PM +, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > I'm not sure this makes sense for these constants. > > Device Check seems more readable than ACPI_DEV_CHK. > If your object here i

Re: [Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values

2014-12-08 Thread Michael S. Tsirkin
On Mon, Dec 08, 2014 at 04:08:06PM +, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov I'm not sure this makes sense for these constants. Device Check seems more readable than ACPI_DEV_CHK. If your object here is readability, please do not abbreviate. Generally ability to match spec name

[Qemu-devel] [PATCH 7/9] acpi: replace opencoded notify codes with named values

2014-12-08 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 4 ++-- include/hw/acpi/acpi_gen_utils.h | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0f6202d..a33d130 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i38