Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 11:37, Alexey Kardashevskiy ha scritto: > On 06/03/2013 06:07 PM, Benjamin Herrenschmidt wrote: >> On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: >>> Ok. I implemented {save|load}_request for IBMVSCSI, started testing - >>> the >>> destination system behaves very unsta

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Alexey Kardashevskiy
On 06/03/2013 06:07 PM, Benjamin Herrenschmidt wrote: > On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: >> Ok. I implemented {save|load}_request for IBMVSCSI, started testing - >> the >> destination system behaves very unstable, sometime it is a fault in >> _raw_spin_lock or it looks

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-03 Thread Benjamin Herrenschmidt
On Mon, 2013-06-03 at 15:46 +1000, Alexey Kardashevskiy wrote: > Ok. I implemented {save|load}_request for IBMVSCSI, started testing - > the > destination system behaves very unstable, sometime it is a fault in > _raw_spin_lock or it looks okay but any attempt to read the filesystem > leads to 100%

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-02 Thread Paolo Bonzini
Il 03/06/2013 07:46, Alexey Kardashevskiy ha scritto: > Ok. I implemented {save|load}_request for IBMVSCSI, started testing - the > destination system behaves very unstable, sometime it is a fault in > _raw_spin_lock or it looks okay but any attempt to read the filesystem > leads to 100% cpu load i

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-02 Thread Paolo Bonzini
Il 01/06/2013 02:01, Benjamin Herrenschmidt ha scritto: > On Fri, 2013-05-31 at 12:41 +0200, Paolo Bonzini wrote: > >> It may be halfway through, but it is always restarted on the destination. > > "restarted" as in the whole transfer is restarted if any right ? So we > can essentially consider as

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-06-02 Thread Alexey Kardashevskiy
On 05/31/2013 08:41 PM, Paolo Bonzini wrote: > Il 31/05/2013 12:25, Alexey Kardashevskiy ha scritto: >> On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: >>> On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: And another question (sorry I am not very familiar with terminol

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Benjamin Herrenschmidt
On Fri, 2013-05-31 at 12:41 +0200, Paolo Bonzini wrote: > It may be halfway through, but it is always restarted on the destination. "restarted" as in the whole transfer is restarted if any right ? So we can essentially consider as a new request for which we just did scsi_req_enqueue() ? IE. We d

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:25, Alexey Kardashevskiy ha scritto: > On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: >> On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: >>> >>> And another question (sorry I am not very familiar with terminology but >>> cc:Ben is :) ) - what happens with indi

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:33, Alexey Kardashevskiy ha scritto: > How do you trigger the situation when there are inactive requests which > have to be migrated? You need to trigger an error. For example, you could use a sparse image on an almost-full partition and let "dd" fill your d

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 08:26 PM, Paolo Bonzini wrote: > Il 31/05/2013 12:12, Alexey Kardashevskiy ha scritto: >> On 05/31/2013 06:18 PM, Paolo Bonzini wrote: >>> Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: On 05/27/2013 05:03 PM, Paolo Bonzini wrote: > Il 27/05/2013 08:48, Alexey Kardashe

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 12:12, Alexey Kardashevskiy ha scritto: > On 05/31/2013 06:18 PM, Paolo Bonzini wrote: >> Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: >>> On 05/27/2013 05:03 PM, Paolo Bonzini wrote: Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: >>> >>> This is only true

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 08:07 PM, Benjamin Herrenschmidt wrote: > On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: >> >> And another question (sorry I am not very familiar with terminology but >> cc:Ben is :) ) - what happens with indirect requests if migration happened >> in the middle of hand

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Alexey Kardashevskiy
On 05/31/2013 06:18 PM, Paolo Bonzini wrote: > Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: >> On 05/27/2013 05:03 PM, Paolo Bonzini wrote: >>> Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: >> >> This is only true when the rerror and werror options have the values >> "i

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Benjamin Herrenschmidt
On Fri, 2013-05-31 at 15:58 +1000, Alexey Kardashevskiy wrote: > > And another question (sorry I am not very familiar with terminology but > cc:Ben is :) ) - what happens with indirect requests if migration happened > in the middle of handling such a request? virtio-scsi does not seem to > handle

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: > On 05/27/2013 05:03 PM, Paolo Bonzini wrote: >> Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: > > This is only true when the rerror and werror options have the values > "ignore" or "report". See virtio-scsi for an example

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-30 Thread Alexey Kardashevskiy
On 05/27/2013 05:03 PM, Paolo Bonzini wrote: > Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: This is only true when the rerror and werror options have the values "ignore" or "report". See virtio-scsi for an example of how to save the requests using the save_request and

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: >> > >> > This is only true when the rerror and werror options have the values >> > "ignore" or "report". See virtio-scsi for an example of how to save the >> > requests using the save_request and load_request callbacks in SCSIBusInfo. > > Si

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-26 Thread Alexey Kardashevskiy
On 05/06/2013 05:37 PM, Paolo Bonzini wrote: > Il 03/05/2013 03:38, David Gibson ha scritto: >> This patch adds the necessary support for saving the state of the PAPR VIO >> virtual SCSI device. This turns out to be trivial, because the generiC >> SCSI code already quiesces the attached virtual SC

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-06 Thread Paolo Bonzini
Il 03/05/2013 03:38, David Gibson ha scritto: > This patch adds the necessary support for saving the state of the PAPR VIO > virtual SCSI device. This turns out to be trivial, because the generiC > SCSI code already quiesces the attached virtual SCSI bus. > > Signed-off-by: David Gibson > --- >

[Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-02 Thread David Gibson
This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This turns out to be trivial, because the generiC SCSI code already quiesces the attached virtual SCSI bus. Signed-off-by: David Gibson --- hw/scsi/spapr_vscsi.c | 28