Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> Ian Jackson writes:
> > qemu_strtoul fails (returns an error) if the delimiter (that is, the
> > first character which is not processed as digit by strtoul) is not
> >
Ian Jackson writes:
> Hi. Thanks for the (re)-review.
>
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
> -runasid option"):
>> Ian Jackson writes:
>> > +case QEMU_OPTION_runasid:
>> > +errno = 0;
>&g
Hi. Thanks for the (re)-review.
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> Ian Jackson writes:
> > +case QEMU_OPTION_runasid:
> > +errno = 0;
> > +lv = strtoul(optarg, &ep,
Sorry for the slow response.
Ian Jackson writes:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> Signed-off-by: Ian Jackson
> ---
> v3: Error messages fixed. Thanks to Pe
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> Actually, a numeric UID without group name or ID could be made to work
> just fine as long as it maps to a user name. The use case may not be
> worth the bother, though.
In l
Ian Jackson writes:
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
> -runasid option"):
>> The last thing the QEMU command line needs is more exotic options. Are
>> you sure we need a new one here? Can we make existing -runas ser
Daniel P. Berrange writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> Just use getpwuid() to get the "struct passwd *", then change_process_uid()
> doesn't need any changes at all AFAICT.
See my comments in the commit message. There
On Mon, Oct 09, 2017 at 04:05:10PM +0100, Ian Jackson wrote:
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
> -runasid option"):
> > The last thing the QEMU command line needs is more exotic options. Are
> > you sure we need a new one
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> The last thing the QEMU command line needs is more exotic options. Are
> you sure we need a new one here? Can we make existing -runas serve?
> Precedence: Coreutils[*]. Pseud
Ian Jackson writes:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> Signed-off-by: Ian Jackson
[...]
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9f6e2ad..34a5329 1
This allows the caller to specify a uid and gid to use, even if there
is no corresponding password entry. This will be useful in certain
Xen configurations.
Signed-off-by: Ian Jackson
---
v3: Error messages fixed. Thanks to Peter Maydell and Ross Lagerwall.
v2: Coding style fixes.
---
os-posix
Ross Lagerwall writes ("Re: [PATCH 7/8] os-posix: Provide new -runasid option"):
> On 10/04/2017 05:18 PM, Ian Jackson wrote:
> > -if (setuid(user_pwd->pw_uid) < 0) {
> > +if (setuid(user_pwd ? user_pwd->pw_uid : user_gid) < 0) {
> > fprintf(stderr, "Failed to setuid(%
Peter Maydell writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
-runasid option"):
> On 4 October 2017 at 17:18, Ian Jackson wrote:
> > static void change_process_uid(void)
> > {
> > -if (user_pwd) {
> > -if (setgid(user_pwd-
On 4 October 2017 at 17:18, Ian Jackson wrote:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> Signed-off-by: Ian Jackson
> ---
> @@ -166,17 +187,19 @@ void os_parse_cmd_args(
On 10/04/2017 05:18 PM, Ian Jackson wrote:
This allows the caller to specify a uid and gid to use, even if there
is no corresponding password entry. This will be useful in certain
Xen configurations.
Signed-off-by: Ian Jackson
snip
@@ -166,17 +187,19 @@ void os_parse_cmd_args(int index, cons
This allows the caller to specify a uid and gid to use, even if there
is no corresponding password entry. This will be useful in certain
Xen configurations.
Signed-off-by: Ian Jackson
---
v2: Coding style fixes.
---
os-posix.c | 31 +++
qemu-options.hx | 12
This allows the caller to specify a uid and gid to use, even if there
is no corresponding password entry. This will be useful in certain
Xen configurations.
Signed-off-by: Ian Jackson
---
v2: Coding style fixes.
---
os-posix.c | 31 +++
qemu-options.hx | 12
17 matches
Mail list logo
