Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-12 Thread Paolo Bonzini
On 11/07/2018 19:52, Emanuele wrote: >>> >> Do you intend to delete this comment before this series is merged?  It >> seems like a TODO that doesn't need to be kept around. > Paolo suggested me to put it there, because there still are some devices > that need to be implemented. >> >>> +    qos_add_

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Emanuele
On 07/11/2018 05:15 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: +/** + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. Paolo suggest

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: > +/** > + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. > +qos_add_test("sdhci-test", "sdhci", test_machine);

[Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-09 Thread Emanuele Giuseppe Esposito
Convert tests/sdhci-test in first qgraph test node, sdhci-test. This test consumes an sdhci interface and checks that its function return the expected values. Note that this test does not allocate any sdhci structure, it's all done by the qtest walking graph mechanism Signed-off-by: Emanuele Gius