On 05/29/2013 01:15 PM, Luiz Capitulino wrote:
On Thu, 23 May 2013 13:44:47 -0400
Corey Bryant wrote:
Signed-off-by: Corey Bryant
Looks good to me, only one small nit below.
It looks like this series is going to get dropped, but thanks for the
review!
--
Regards,
Corey Bryant
---
On Thu, 23 May 2013 13:44:47 -0400
Corey Bryant wrote:
> Signed-off-by: Corey Bryant
Looks good to me, only one small nit below.
> ---
> hmp.c| 32
> hmp.h|1 +
> monitor.c|7 +
> qapi-schema.json | 47 ++
On 05/23/2013 01:59 PM, Eric Blake wrote:
On 05/23/2013 11:44 AM, Corey Bryant wrote:
Signed-off-by: Corey Bryant
---
Might help to list a sample HMP or QMP usage in the commit message.
+++ b/qapi-schema.json
@@ -3619,3 +3619,50 @@
'*cpuid-input-ecx': 'int',
'c
On 05/23/2013 11:44 AM, Corey Bryant wrote:
> Signed-off-by: Corey Bryant
> ---
Might help to list a sample HMP or QMP usage in the commit message.
> +++ b/qapi-schema.json
> @@ -3619,3 +3619,50 @@
> '*cpuid-input-ecx': 'int',
> 'cpuid-register': 'X86CPURegister32',
>
Signed-off-by: Corey Bryant
---
hmp.c| 32
hmp.h|1 +
monitor.c|7 +
qapi-schema.json | 47 +++
qmp-commands.hx | 41 +++
vnvram.c | 71 +++
