Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 12:20 PM Peter Xu wrote: > > On Tue, Aug 28, 2018 at 11:09:28AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > > > > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > > > terminal3270 is uses th

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Peter Xu
On Tue, Aug 28, 2018 at 11:09:28AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > > terminal3270 is uses the front-end side of the chardev. It shouldn't > > > create sources fr

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 5:52 AM Peter Xu wrote: > > On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > > terminal3270 is uses the front-end side of the chardev. It shouldn't > > create sources from backend side context. Fwiw, send_timing_mark_cb > > calls qemu_chr_fe_write_al

Re: [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-27 Thread Peter Xu
On Tue, Aug 28, 2018 at 12:23:19AM +0200, Marc-André Lureau wrote: > terminal3270 is uses the front-end side of the chardev. It shouldn't > create sources from backend side context. Fwiw, send_timing_mark_cb > calls qemu_chr_fe_write_all() which should be thread safe. > > This partially reverts ch

[Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources

2018-08-27 Thread Marc-André Lureau
terminal3270 is uses the front-end side of the chardev. It shouldn't create sources from backend side context. Fwiw, send_timing_mark_cb calls qemu_chr_fe_write_all() which should be thread safe. This partially reverts changes from commit 2c716ba1506769c9be2caa02f0f6d6e7c00f4304. CC: Peter Xu Si