[Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

This should catch many kinds of errors that the current code wasn't checking for: - Values that can't be parsed as a number - Negative values - Overflow - Empty string Signed-off-by: Eduardo Habkost Reviewed-by: Eric Blake --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

On Wed, Jan 16, 2013 at 10:25:31AM -0700, Eric Blake wrote: > On 01/16/2013 08:24 AM, Eduardo Habkost wrote: > > This should catch many kinds of errors that the current code wasn't > > checking for: > > > > - Values that can't be parsed as a number > > - Negative values > > - Overflow > > - Em

[Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

This should catch many kinds of errors that the current code wasn't checking for: - Values that can't be parsed as a number - Negative values - Overflow - Empty string Signed-off-by: Eduardo Habkost --- Cc: Eric Blake Changes v2: - Use base=10 to keep the existing behavior --- vl.c | 5 +

[Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

This should catch many kinds of errors that the current code wasn't checking for: - Values that can't be parsed as a number - Negative values - Overflow - Empty string Signed-off-by: Eduardo Habkost --- Cc: Eric Blake --- vl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) d

Re: [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

On Wed, Jan 16, 2013 at 10:54:34AM -0700, Eric Blake wrote: > On 01/16/2013 10:42 AM, Eduardo Habkost wrote: > > > > Or, we could simply change the meaning of "nodeid=010" and document it > > in the commit message and QEMU ChageLog. Which option do the QEMU > > maintainers prefer? > > I'm not a m

Re: [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

On 01/16/2013 10:42 AM, Eduardo Habkost wrote: > > Or, we could simply change the meaning of "nodeid=010" and document it > in the commit message and QEMU ChageLog. Which option do the QEMU > maintainers prefer? I'm not a maintainer, so anyone is free to overrule me; but I'm personally fine with

Re: [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid

On 01/16/2013 08:24 AM, Eduardo Habkost wrote: > This should catch many kinds of errors that the current code wasn't > checking for: > > - Values that can't be parsed as a number > - Negative values > - Overflow > - Empty string > > Signed-off-by: Eduardo Habkost > --- > Cc: Eric Blake > --