Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-08-31 Thread Eric Blake
On 08/31/2015 04:39 PM, Eric Blake wrote: +++ b/block/qcow2.c @@ -182,6 +182,14 @@ static int qcow2_read_extensions(BlockDriverState *bs, uint64_t start_offset, return ret; } +if (!(s->autoclear_features & QCOW2_AUTOC

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-08-31 Thread Eric Blake
On 08/27/2015 01:45 AM, Vladimir Sementsov-Ogievskiy wrote: > On 09.06.2015 18:50, Stefan Hajnoczi wrote: >> On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy >> wrote: >>> diff --git a/block/qcow2.c b/block/qcow2.c >>> index 406e55d..f85a55a 100644 >>> --- a/block/qcow2.c >>>

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-08-31 Thread Vladimir Sementsov-Ogievskiy
On 27.08.2015 10:45, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 18:50, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 406e55d..f85a55a 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-08-27 Thread Vladimir Sementsov-Ogievskiy
On 09.06.2015 18:50, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 406e55d..f85a55a 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -182,6 +182,14 @@ static int qcow2_read_extensions(BlockDr

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread John Snow
On 06/11/2015 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: > On 11.06.2015 02:42, John Snow wrote: >> >> On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/qcow2-dirty-bitmap

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 11.06.2015 02:42, John Snow wrote: On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c | 13 +++-- block/qcow2.h

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread Kevin Wolf
Am 11.06.2015 um 01:42 hat John Snow geschrieben: > > > On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > > From: Vladimir Sementsov-Ogievskiy > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > block/qcow2-dirty-bitmap.c | 5 + > > block/qcow2.c | 13

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-10 Thread John Snow
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-dirty-bitmap.c | 5 + > block/qcow2.c | 13 +++-- > block/qcow2.h | 9 + > 3 fil

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-09 Thread Stefan Hajnoczi
On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/qcow2.c b/block/qcow2.c > index 406e55d..f85a55a 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -182,6 +182,14 @@ static int qcow2_read_extensions(BlockDriverState *bs, > uint64_t start_offs

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-09 Thread Stefan Hajnoczi
On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -928,8 +936,9 @@ static int qcow2_open(BlockDriverState *bs, QDict > *options, int flags, > } > > /* Clear unknown autoclear feature bits */ > -if (!bs->read_only && !(flags & BDRV_O_INCOMING) && >

[Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-08 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c | 13 +++-- block/qcow2.h | 9 + 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/block/qcow2-dirty-b