Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:53PM -0700, Eduardo Habkost wrote: [...] > -env->gregs[1] = 0; // Memory start > -env->gregs[2] = ram_size; // Memory size > -env->gregs[3] = 0; // Machine description XXX > +env->gregs[1] = 0; /* Memory start */ > +env->gregs[2] = ram_size; /* Memo

Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:53PM -0700, Eduardo Habkost wrote: > I am sending a single patch for all machines to get some feedback, but > in the final patch series I will separate them by architecture. There are some checkpatch.pl issues introduced by this (long lines and trailing spaces), I wil

[Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-18 Thread Eduardo Habkost
I am sending a single patch for all machines to get some feedback, but in the final patch series I will separate them by architecture. Cc: Richard Henderson Cc: Peter Maydell Cc: Li Guang Cc: Antony Pavlov Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Cc: Rob