Re: [Qemu-devel] [PATCH 6/6] target-arm/cpu.h: document why env->spsr exists

2015-03-11 Thread Peter Maydell
On 25 February 2015 at 16:02, Alex Bennée wrote: > I was getting very confused about the duplication of state. Perhaps we > should just get rid of env->spsr and use helpers that understand the > banking? I've already disagreed with this. I would suggest putting tentative questions about future di

Re: [Qemu-devel] [PATCH 6/6] target-arm/cpu.h: document why env->spsr exists

2015-03-11 Thread Greg Bellows
On Wed, Feb 25, 2015 at 10:02 AM, Alex Bennée wrote: > I was getting very confused about the duplication of state. Perhaps we > should just get rid of env->spsr and use helpers that understand the > banking? > > Signed-off-by: Alex Bennée > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > ind