Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-30 Thread Wenchao Xia
于 2013/10/30 7:02, Eric Blake 写道: On 10/22/2013 06:37 PM, Wenchao Xia wrote: Hi, here is my draft for qapi-schema.json, please have a look. Note: 1 it requires directly support of 'base', so I will sent additonal patch support it by key word '_base' in 'data' contents. 2 some define not labeled

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-29 Thread Eric Blake
On 10/22/2013 06:37 PM, Wenchao Xia wrote: > Hi, here is my draft for qapi-schema.json, please have a look. > Note: > 1 it requires directly support of 'base', so I will sent additonal patch > support it by key word '_base' in 'data' contents. > 2 some define not labeled with "since 1.8', are code

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-23 Thread Wenchao Xia
Take another think, I think I may use past tense through the doc, but with more carefully meaning, such as: the system has enter powerdown state. If you agree with the tense, I'd like sent the reformed doc in the following, before respin. Indeed, which is why separating the docs from the

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-22 Thread Wenchao Xia
于 2013/10/22 14:55, Wenchao Xia 写道: 于 2013/10/22 5:00, Eric Blake 写道: On 10/21/2013 03:16 AM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- qapi-schema.json | 56 ++ 1 files changed, 56 insertions(+), 0 deletions(-) Incomplete. N

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-22 Thread Eric Blake
On 10/22/2013 07:55 AM, Wenchao Xia wrote: > 于 2013/10/22 5:00, Eric Blake 写道: >> On 10/21/2013 03:16 AM, Wenchao Xia wrote: >>> Signed-off-by: Wenchao Xia >>> --- >>> qapi-schema.json | 56 >>> ++ >>> 1 files changed, 56 insertions(+), 0 de

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-22 Thread Wenchao Xia
于 2013/10/22 5:00, Eric Blake 写道: On 10/21/2013 03:16 AM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- qapi-schema.json | 56 ++ 1 files changed, 56 insertions(+), 0 deletions(-) Incomplete. Now that you are actually using the enum

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-21 Thread Eric Blake
On 10/22/2013 04:19 AM, Wenchao Xia wrote: >>> +# >>> +# @POWERDOWN: system power down, if it is suppoted >> s/suppoted/supported/ >> >> Events aren't issued if they aren't supported, so that phrase is >> pointless. > Ok, I will skip that phrase. The point here is that, many people are > confuse

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-21 Thread Wenchao Xia
于 2013/10/22 5:00, Eric Blake 写道: On 10/21/2013 03:16 AM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- qapi-schema.json | 56 ++ 1 files changed, 56 insertions(+), 0 deletions(-) Incomplete. Now that you are actually using the enum

Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-21 Thread Eric Blake
On 10/21/2013 03:16 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > qapi-schema.json | 56 > ++ > 1 files changed, 56 insertions(+), 0 deletions(-) Incomplete. Now that you are actually using the enum (see the spot I pointed out

[Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent

2013-10-21 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- qapi-schema.json | 56 ++ 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index fbc1fab..0f966ab 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -33,6 +