Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-30 Thread Paolo Bonzini
Il 30/04/2013 05:51, Jordan Justen ha scritto: > The rom in qemu is read-only. In kvm, it has been read-write. That is > different behavior. And it was a problem, hence it was reverted. > I assume with kvm readonly support, at some point the rom may be > read-only or read/write under kvm dependin

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Jordan Justen
On Mon, Apr 29, 2013 at 2:10 PM, Paolo Bonzini wrote: > Il 29/04/2013 20:23, Jordan Justen ha scritto: >> On Mon, Apr 29, 2013 at 1:20 AM, Paolo Bonzini wrote: >>> Il 28/04/2013 10:32, Jordan Justen ha scritto: Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 20:23, Jordan Justen ha scritto: > On Mon, Apr 29, 2013 at 1:20 AM, Paolo Bonzini wrote: >> Il 28/04/2013 10:32, Jordan Justen ha scritto: >>> Now KVM can support a flash memory. This feature depends on >>> KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. >> >> I don't think

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Jordan Justen
On Mon, Apr 29, 2013 at 1:20 AM, Paolo Bonzini wrote: > Il 28/04/2013 10:32, Jordan Justen ha scritto: >> Now KVM can support a flash memory. This feature depends on >> KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. > > I don't think we can require such a new kernel to run KVM. IIUC, an

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Markus Armbruster
Jordan Justen writes: > Now KVM can support a flash memory. This feature depends on > KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. > > Signed-off-by: Jordan Justen > --- > hw/block/pc_sysfw.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/pc_sys

Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-29 Thread Paolo Bonzini
Il 28/04/2013 10:32, Jordan Justen ha scritto: > Now KVM can support a flash memory. This feature depends on > KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. I don't think we can require such a new kernel to run KVM. IIUC, an older kernel would just fail to start, right? Paolo

[Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0

2013-04-28 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c index e88d67e