Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-21 Thread Fam Zheng
On Thu, 08/21 11:02, Paolo Bonzini wrote: > Il 21/08/2014 05:54, Fam Zheng ha scritto: > >> > In any case, if we need it I think there's no need to keep the argument > >> > to iqn_generate. > > How about multiple initiators? Should they use the same iqn? > > block/iscsi.c uses -iscsi for the optio

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 05:54, Fam Zheng ha scritto: >> > In any case, if we need it I think there's no need to keep the argument >> > to iqn_generate. > How about multiple initiators? Should they use the same iqn? block/iscsi.c uses -iscsi for the options so that you don't have to place them in cleartext i

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Fam Zheng
On Wed, 08/20 15:32, Paolo Bonzini wrote: > > In any case, if we need it I think there's no need to keep the argument > to iqn_generate. How about multiple initiators? Should they use the same iqn? Fam

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Fam Zheng
On Wed, 08/20 15:32, Paolo Bonzini wrote: > Il 20/08/2014 12:01, Fam Zheng ha scritto: > > diff --git a/util/iqn.c b/util/iqn.c > > new file mode 100644 > > index 000..c8d1eda > > --- /dev/null > > +++ b/util/iqn.c > > @@ -0,0 +1,38 @@ > > +/* > > + * iqn generat function > > + * > > + * Copyri

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > Function qmp_query_uuid, even with a version in libqemustub.a, is not > present in qemu-img, unless we move it to something that is linked with > block-obj-y. Since it's a helper function, move it to util makes sense. > > Signed-off-by: Fam Zheng > ---

[Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Fam Zheng
Function qmp_query_uuid, even with a version in libqemustub.a, is not present in qemu-img, unless we move it to something that is linked with block-obj-y. Since it's a helper function, move it to util makes sense. Signed-off-by: Fam Zheng --- block/iscsi.c | 15 +-- include/q