Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 17:05, Laszlo Ersek wrote: > > Yet another question -- as far as I understand, I should have enough > info (with my pending questions of course) for EFI_SMM_ACCESS2_PROTOCOL. > I've now reviewed EFI_SMM_CONTROL2_PROTOCOL too, and AFAICS the only > thing I need to know for it is "ho

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
> > tseg_blackhole is added on top of address_space_memory to hide TSEG; > > tseg_window is included in /machine/smram and TCG adds it to the private > > per-CPU address space when it enters system management mode. > > Hm, I must have missed this (or not seen it at all) -- should I have > noticed

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
Hi, > > I'm thinking, the last 1 / 2 / 8 megabytes should behave as RAM in all > > of the following cases: > > - no SMRAM programmed (tseg size = 0) > > - SMRAM programmed (tseg size > 0), and it is open > > - SMRAM programmed (tseg size > 0) and closed, but CPU in SMM > > Correct. Almost. I

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/21/15 16:38, Paolo Bonzini wrote: > > > On 21/04/2015 16:30, Laszlo Ersek wrote: -MemoryRegion tseg_blackhole; +MemoryRegion tseg_blackhole, tseg_window; PcPciInfo pci_info; ram_addr_t below_4g_mem_size; ram_addr_t above_4g_mem_size; >> W

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:30, Laszlo Ersek wrote: >> > -MemoryRegion tseg_blackhole; >> > +MemoryRegion tseg_blackhole, tseg_window; >> > PcPciInfo pci_info; >> > ram_addr_t below_4g_mem_size; >> > ram_addr_t above_4g_mem_size; >> > > Why is this necessary? If you disable the black

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/20/15 11:19, Gerd Hoffmann wrote: > add tseg window to smram region, so cpus can access it in smm mode. > > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/q35.c | 13 + > include/hw/pci-host/q35.h | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff -

[Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-20 Thread Gerd Hoffmann
add tseg window to smram region, so cpus can access it in smm mode. Signed-off-by: Gerd Hoffmann --- hw/pci-host/q35.c | 13 + include/hw/pci-host/q35.h | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 412ff0a