Re: [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev

2018-08-30 Thread Marc-André Lureau
Hi On Thu, Aug 30, 2018 at 4:58 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > It is futile to call qemu_chr_fe_set_handlers() without an associated > > chardev, because the function is doing nothing in that case, not even > > reporting an error, it would likely be a programming

Re: [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev

2018-08-30 Thread Markus Armbruster
Marc-André Lureau writes: > It is futile to call qemu_chr_fe_set_handlers() without an associated > chardev, because the function is doing nothing in that case, not even > reporting an error, it would likely be a programming error. Let's not > handle that hypothetical case. > > (fwiw, I introduce

[Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev

2018-08-27 Thread Marc-André Lureau
It is futile to call qemu_chr_fe_set_handlers() without an associated chardev, because the function is doing nothing in that case, not even reporting an error, it would likely be a programming error. Let's not handle that hypothetical case. (fwiw, I introduced the check in commit 94a40fc56036b5058