Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 16:56, Alberto Garcia wrote: > On Wed 29 Aug 2018 02:59:01 PM CEST, Max Reitz wrote: Specifically, that means when you don't specify @backing, the default chain will be opened and may replace the current one. >>> >>> At the moment "backing" is the only child option that can

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Alberto Garcia
On Wed 29 Aug 2018 02:59:01 PM CEST, Max Reitz wrote: >>> Specifically, that means when you don't specify @backing, the default >>> chain will be opened and may replace the current one. >> >> At the moment "backing" is the only child option that can be omitted, >> all others must be specified. So

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 14:59, Max Reitz wrote: > On 2018-08-29 14:29, Alberto Garcia wrote: >> On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: [...] >>> So why isn't it mandatory to re-specify all children for now? >> >> It is > Is it? Why does > > $ qemu-io -c 'reopen -o lazy-refcounts=on' foo.qc

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 14:29, Alberto Garcia wrote: > On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: >> On 2018-08-26 16:09, Alberto Garcia wrote: >>> In the previous patches we removed all child references from >>> bs->{options,explicit_options} because keeping them is useless and >>> wrong. >>> >>>

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Alberto Garcia
On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: > On 2018-08-26 16:09, Alberto Garcia wrote: >> In the previous patches we removed all child references from >> bs->{options,explicit_options} because keeping them is useless and >> wrong. >> >> Because of this, any attempt to reopen a BlockDri

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > In the previous patches we removed all child references from > bs->{options,explicit_options} because keeping them is useless and > wrong. > > Because of this, any attempt to reopen a BlockDriverState using a > child reference as one of its options woul

[Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-26 Thread Alberto Garcia
In the previous patches we removed all child references from bs->{options,explicit_options} because keeping them is useless and wrong. Because of this, any attempt to reopen a BlockDriverState using a child reference as one of its options would result in a failure, because bdrv_reopen_prepare() wo