Re: [Qemu-devel] [PATCH 5/8] tcg: Remove stray semi-colons from target-*/helper.h

2013-09-15 Thread Peter Maydell
On 15 September 2013 08:03, Stefan Weil wrote: > Instead of removing the semicolons from the DEF_HELPER_x lines, > I'd prefer removing them from the DEF_HELPER_FLAGS_x definitions. > > Code formatters and static code analyzers (maybe humans, too) prefer > lines which look like valid C syntax, ther

Re: [Qemu-devel] [PATCH 5/8] tcg: Remove stray semi-colons from target-*/helper.h

2013-09-15 Thread Stefan Weil
Am 15.09.2013 02:03, schrieb Richard Henderson: > During GEN_HELPER=1, these are actually stray top-level semi-colons > which are technically invalid ISO C, but GCC accepts as an extension. > If we added enough __extension__ markers that we could dare use > -Wpedantic, we'd see > > warning: ISO C

[Qemu-devel] [PATCH 5/8] tcg: Remove stray semi-colons from target-*/helper.h

2013-09-14 Thread Richard Henderson
During GEN_HELPER=1, these are actually stray top-level semi-colons which are technically invalid ISO C, but GCC accepts as an extension. If we added enough __extension__ markers that we could dare use -Wpedantic, we'd see warning: ISO C does not allow extra ‘;’ outside of a function This will