Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:22:30PM +0100, Paolo Bonzini wrote: > On 19/12/2014 03:41, Eduardo Habkost wrote: > > +object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id", > > +&error); > > +if (error) { > > +goto out; > > +} > > + > > Sho

Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 03:41, Eduardo Habkost wrote: > +object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id", > +&error); > +if (error) { > +goto out; > +} > + Should this use &error_abort? Paolo

[Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

2014-12-18 Thread Eduardo Habkost
The PC CPU initialization code already sets apic-id based on the CPU topology, and CONFIG_USER doesn't need the topology-based APIC ID calculation code. Make CONFIG_USER set apic-id before realizing the CPU (just like PC already does), so we can simplify x86_cpu_initfn later. As there is no CPU to