On 11/30/2009 03:31 PM, Glauber Costa wrote:
Only does get. And we need put.
It will autoput during the next guest entry.
So it should be working already, no?
We do a cpu_synchronize_state() on the beginning of that function, and
vcpu does not run
until it is finished
Yes.
On Mon, Nov 30, 2009 at 10:05 AM, Avi Kivity wrote:
> On 11/30/2009 01:45 PM, Glauber Costa wrote:
>>>
>>> Better to use cpu_synchronize_state() instead.
>>>
>>>
>>
>> I might be misreading it, but :
>>
>> void kvm_cpu_synchronize_state(CPUState *env)
>> {
>> if (!env->kvm_state->regs_modified
On 11/30/2009 01:45 PM, Glauber Costa wrote:
Better to use cpu_synchronize_state() instead.
I might be misreading it, but :
void kvm_cpu_synchronize_state(CPUState *env)
{
if (!env->kvm_state->regs_modified) {
kvm_arch_get_registers(env);
env->kvm_state->regs_modi
On Mon, Nov 30, 2009 at 09:45:56AM -0200, Glauber Costa wrote:
> >> since
> >> + * apic base was just updated
> >> + */
> >> + kvm_arch_put_registers(s->cpu_env);
> >>
> >>
> >
> > Better to use cpu_synchronize_state() instead.
> >
> I might be misreading it, but :
>
> void kvm_cpu_sync
>> since
>> + * apic base was just updated
>> + */
>> + kvm_arch_put_registers(s->cpu_env);
>>
>>
>
> Better to use cpu_synchronize_state() instead.
>
I might be misreading it, but :
void kvm_cpu_synchronize_state(CPUState *env)
{
if (!env->kvm_state->regs_modified) {
kvm_ar
On 11/26/2009 07:24 PM, Glauber Costa wrote:
This fix a bug with -smp in kvm. Since we have updated apic_base,
we also have to tell kernel about it. So instead of just updating
mp_state, update every regs.
Signed-off-by: Glauber Costa
---
hw/apic-kvm.c |5 -
1 files changed, 4 inserti
This fix a bug with -smp in kvm. Since we have updated apic_base,
we also have to tell kernel about it. So instead of just updating
mp_state, update every regs.
Signed-off-by: Glauber Costa
---
hw/apic-kvm.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/apic-kvm
