Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:37 PM, Alexander Graf wrote: On 07.01.15 12:32, Paolo Bonzini wrote: On 07/01/2015 12:27, Alexander Graf wrote: Hmm, then I guess let's apply these patches and fix things up later? Certainly works for me ;). Send a pull request then. :) Ok, applied the patch set to pp

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:27, Alexander Graf wrote: > > Hmm, then I guess let's apply these patches and fix things up later? > > Certainly works for me ;). Send a pull request then. :) Paolo

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/06/2015 10:45 PM, Paolo Bonzini wrote: On 06/01/2015 14:29, Marcel Apfelbaum wrote: @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) /* Graphics */ if (spapr_vga_init(phb->bus)) { spapr->has_graphics = true; +machine->usb |= defaults_

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:15, Alexander Graf wrote: > > > On 07.01.15 12:07, Paolo Bonzini wrote: >> >> >> On 07/01/2015 12:03, Marcel Apfelbaum wrote: >>> >>> While I agree it will be better if we place this in instance_init, >>> setting the machine_usb to defaults_enabled() there would be problematic

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:07, Paolo Bonzini wrote: > > > On 07/01/2015 12:03, Marcel Apfelbaum wrote: >> >> While I agree it will be better if we place this in instance_init, >> setting the machine_usb to defaults_enabled() there would be problematic >> since it depends on >> - papr_vga_init(phb->bus) fo

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:32, Paolo Bonzini wrote: > > > On 07/01/2015 12:27, Alexander Graf wrote: >>> Hmm, then I guess let's apply these patches and fix things up later? >> >> Certainly works for me ;). > > Send a pull request then. :) Ok, applied the patch set to ppc-next. Now let's see how much of

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:22, Paolo Bonzini wrote: > > > On 07/01/2015 12:15, Alexander Graf wrote: >> >> >> On 07.01.15 12:07, Paolo Bonzini wrote: >>> >>> >>> On 07/01/2015 12:03, Marcel Apfelbaum wrote: While I agree it will be better if we place this in instance_init, setting the machin

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:03, Marcel Apfelbaum wrote: > > While I agree it will be better if we place this in instance_init, > setting the machine_usb to defaults_enabled() there would be problematic > since it depends on > - papr_vga_init(phb->bus) for sparpr and That's effectively vga_interface_type

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:15 PM, Alexander Graf wrote: On 07.01.15 12:07, Paolo Bonzini wrote: On 07/01/2015 12:03, Marcel Apfelbaum wrote: While I agree it will be better if we place this in instance_init, setting the machine_usb to defaults_enabled() there would be problematic since it depends on

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) > /* Graphics */ > if (spapr_vga_init(phb->bus)) { > spapr->has_graphics = true; > +machine->usb |= defaults_enabled(); > } Could the solution b

[Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-06 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 72c3102..53c4116 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine)