Luiz Capitulino writes:
> On Tue, 15 Dec 2009 10:42:46 +0100
> Markus Armbruster wrote:
>
>> Before the code motion, we throw QERR_UNDEFINED_ERROR on
>> monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain
>> why that's okay?
>
> We never did that. A call like that will just se
On Tue, 15 Dec 2009 10:42:46 +0100
Markus Armbruster wrote:
> Before the code motion, we throw QERR_UNDEFINED_ERROR on
> monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain
> why that's okay?
We never did that. A call like that will just segfault QEMU
w/o this fix.
Luiz Capitulino writes:
> The monitor_vprintf() function now touches the 'mon' pointer
> before calling monitor_puts(), this causes block migration
> to segfault as its functions call monitor_printf() with a
> NULL 'mon'.
I figure this worked fine until commit 4a29a85d made monitor_vprintf()
der
The monitor_vprintf() function now touches the 'mon' pointer
before calling monitor_puts(), this causes block migration
to segfault as its functions call monitor_printf() with a
NULL 'mon'.
To fix the problem this commit moves the 'mon' NULL check
from monitor_puts() to monitor_vprintf().
This ca
