Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Sep 19, 2017 at 07:00:38PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > vmstate_save is called in a few places, and vmstate_save_state is > > called in lots of places. > > > > Route error returns from the ea

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Tue, 19 Sep 2017 19:00:38 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > vmstate_save is called in a few places, and vmstate_save_state is > > called in lots of places. > > > > Route error returns from

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Cornelia Huck
On Wed, 20 Sep 2017 16:57:39 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 19 Sep 2017 19:00:38 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > vmstate_save is called in a few places, and v

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Eric Blake
On 09/20/2017 09:20 AM, Dr. David Alan Gilbert wrote: >>> /* Save file with vmstate */ >>> -vmstate_save_state(f, desc, obj, NULL); >>> +g_assert(!vmstate_save_state(f, desc, obj, NULL)); >> >> Though this is test code, isn't putting anything with a side effect into an >> assert expre

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Cornelia Huck
On Tue, 19 Sep 2017 19:00:38 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. > > Route error returns from the easier cases back up; there are lots > of more complex c

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Tue, 09/19 19:00, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > vmstate_save is called in a few places, and vmstate_save_state is > > called in lots of places. > > > > Route error returns from the easier cases back up; t

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-20 Thread Eric Blake
On 09/19/2017 10:55 PM, Fam Zheng wrote: > On Tue, 09/19 19:00, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> vmstate_save is called in a few places, and vmstate_save_state is >> called in lots of places. >> >> Route error returns from the easier cases back up; there

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-19 Thread Fam Zheng
On Tue, 09/19 19:00, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. > > Route error returns from the easier cases back up; there are lots > of more complex cases where there o

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 07:00:38PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. > > Route error returns from the easier cases back up; there are lots > of more comple

[Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" vmstate_save is called in a few places, and vmstate_save_state is called in lots of places. Route error returns from the easier cases back up; there are lots of more complex cases where there own error paths need fixing. Signed-off-by: Dr. David Alan Gilbert ---