Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Paolo Bonzini
- Original Message - > From: "Radim Krčmář" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Peter Xu" , "Igor Mammedov" > , "Richard Henderson" > , "Eduardo Habkost" , "Michael S. > Tsirkin" > Sent: Tuesday, September 27, 2016 4:01:39 PM > Subject: Re: [PATCH 5/5] intel_iommu: do

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Radim Krčmář
2016-09-23 11:27+0200, Paolo Bonzini: > Since the whole IOMMU feature is new and somewhat experimental, I think > it's okay to just make EIM the default for >=2.8 machine types if KVM is > on (using DEFINE_PROP_ON_OFF_AUTO; auto means true if KVM is on and Sounds good. > false otherwise, and pc-2

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Igor Mammedov
On Thu, 22 Sep 2016 23:04:32 +0200 Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is > 8. Make the code simpler by completely forbidding EIM > without KVM's x2apic API. > > Signed-off-by: Radim Krčmář > --- > I think it the dependency wou

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Peter Xu
On Fri, Sep 23, 2016 at 12:39:19PM +0200, Paolo Bonzini wrote: > > > On 23/09/2016 12:12, Peter Xu wrote: > > On Fri, Sep 23, 2016 at 12:03:26PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 23/09/2016 12:02, Peter Xu wrote: > >>> On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: > >

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Paolo Bonzini
On 23/09/2016 12:12, Peter Xu wrote: > On Fri, Sep 23, 2016 at 12:03:26PM +0200, Paolo Bonzini wrote: >> >> >> On 23/09/2016 12:02, Peter Xu wrote: >>> On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: > Since the whole IOMMU feature is new and somewhat experimental, I think

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Peter Xu
On Fri, Sep 23, 2016 at 12:03:26PM +0200, Paolo Bonzini wrote: > > > On 23/09/2016 12:02, Peter Xu wrote: > > On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: > >> > Since the whole IOMMU feature is new and somewhat experimental, I think > >> > it's okay to just make EIM the default

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Paolo Bonzini
On 23/09/2016 12:02, Peter Xu wrote: > On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: >> > Since the whole IOMMU feature is new and somewhat experimental, I think >> > it's okay to just make EIM the default for >=2.8 machine types if KVM is >> > on (using DEFINE_PROP_ON_OFF_AUTO;

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Peter Xu
On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: > Since the whole IOMMU feature is new and somewhat experimental, I think > it's okay to just make EIM the default for >=2.8 machine types if KVM is > on (using DEFINE_PROP_ON_OFF_AUTO; auto means true if KVM is on and > false otherwise

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-23 Thread Paolo Bonzini
On 22/09/2016 23:04, Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is > 8. Make the code simpler by completely forbidding EIM > without KVM's x2apic API. > > Signed-off-by: Radim Krčmář > --- > I think it the dependency would be nicer in

[Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-22 Thread Radim Krčmář
Cluster x2APIC cannot work without KVM's x2apic API when the maximal APIC ID is > 8. Make the code simpler by completely forbidding EIM without KVM's x2apic API. Signed-off-by: Radim Krčmář --- I think it the dependency would be nicer in the eim setter, but the other dependency, for interrup