Re: [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 12:16, Peter Maydell wrote: >> > Using uint32_t is enough and avoids the need to include ioport.h >> > everywhere. >> > >> > Signed-off-by: Paolo Bonzini > I'm not hugely convinced by this patch -- I think it's nice > to have a typedef that indicates that you're dealing with an >

Re: [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

2016-03-16 Thread Peter Maydell
On 16 March 2016 at 10:46, Paolo Bonzini wrote: > Using uint32_t is enough and avoids the need to include ioport.h everywhere. > > Signed-off-by: Paolo Bonzini I'm not hugely convinced by this patch -- I think it's nice to have a typedef that indicates that you're dealing with an IO port address

[Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

2016-03-16 Thread Paolo Bonzini
Using uint32_t is enough and avoids the need to include ioport.h everywhere. Signed-off-by: Paolo Bonzini --- hw/core/sysbus.c | 4 ++-- include/exec/ioport.h | 15 ++- include/hw/sysbus.h | 4 ++-- ioport.c | 12 ++-- xen-hvm.c | 8