Re: [Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:01, Peter Crosthwaite ha scritto: > On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: >> Instead, add a boolean variable to indicate the presence of the region. >> > > Patch is good. Can you add a sentence on why you are doing this > though? Is it just the save on the repeate

Re: [Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias

2014-07-31 Thread Peter Crosthwaite
On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: > Instead, add a boolean variable to indicate the presence of the region. > Patch is good. Can you add a sentence on why you are doing this though? Is it just the save on the repeated malloc and free (which is sane in its own right) or somethi

[Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias

2014-07-30 Thread Paolo Bonzini
Instead, add a boolean variable to indicate the presence of the region. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 24 ++-- hw/display/vga_int.h | 3 ++- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 4