Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 01:32:46PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Jul 5, 2018 at 1:09 PM, Markus Armbruster wrote: > > Peter Xu writes: > > > >> On Thu, Jul 05, 2018 at 10:51:33AM +0200, Markus Armbruster wrote: > >>> Peter Xu writes: > >>> > >>> > It was put into the request

Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-05 Thread Marc-André Lureau
Hi On Thu, Jul 5, 2018 at 1:09 PM, Markus Armbruster wrote: > Peter Xu writes: > >> On Thu, Jul 05, 2018 at 10:51:33AM +0200, Markus Armbruster wrote: >>> Peter Xu writes: >>> >>> > It was put into the request object to show whether we'll need to resume >>> > the monitor after dispatching the c

Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-05 Thread Markus Armbruster
Peter Xu writes: > On Thu, Jul 05, 2018 at 10:51:33AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > It was put into the request object to show whether we'll need to resume >> > the monitor after dispatching the command. Now we move that into the >> > monitor struct so that it mig

Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 10:51:33AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > It was put into the request object to show whether we'll need to resume > > the monitor after dispatching the command. Now we move that into the > > monitor struct so that it might be even used in other p

Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-05 Thread Markus Armbruster
Peter Xu writes: > It was put into the request object to show whether we'll need to resume > the monitor after dispatching the command. Now we move that into the > monitor struct so that it might be even used in other places in the > future, e.g., out-of-band message flow controls. > > One thing

[Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-04 Thread Peter Xu
It was put into the request object to show whether we'll need to resume the monitor after dispatching the command. Now we move that into the monitor struct so that it might be even used in other places in the future, e.g., out-of-band message flow controls. One thing to mention is that there is n