Re: [Qemu-devel] [PATCH 4/7] qga/vss-win32: Document the DLL requires non-null errp

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > requester.cpp uses this pattern to receive an error and pass it on to > the caller (err_is_set() macro peeled off for clarity): > > ... code that may set errset->errp ... > if (errset->errp && *errset->errp) { > ... handle error ..

[Qemu-devel] [PATCH 4/7] qga/vss-win32: Document the DLL requires non-null errp

2015-06-22 Thread Markus Armbruster
requester.cpp uses this pattern to receive an error and pass it on to the caller (err_is_set() macro peeled off for clarity): ... code that may set errset->errp ... if (errset->errp && *errset->errp) { ... handle error ... } This breaks when errset->errp is null. As far as I