Re: [Qemu-devel] [PATCH 4/7] pnv: Clean up cpu realize path

2018-06-13 Thread David Gibson
On Wed, Jun 13, 2018 at 10:20:43AM +0200, Cédric Le Goater wrote: > On 06/13/2018 08:57 AM, David Gibson wrote: > > pnv_cpu_init() is only called from the the pnv cpu core realize path, and > > really only can be called from there. So fold it into its caller, which > > we also rename for brevity.

Re: [Qemu-devel] [PATCH 4/7] pnv: Clean up cpu realize path

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 16:57:04 +1000 David Gibson wrote: > pnv_cpu_init() is only called from the the pnv cpu core realize path, and > really only can be called from there. So fold it into its caller, which > we also rename for brevity. > > Signed-off-by: David Gibson > --- Reviewed-by: Greg Ku

Re: [Qemu-devel] [PATCH 4/7] pnv: Clean up cpu realize path

2018-06-13 Thread Cédric Le Goater
On 06/13/2018 08:57 AM, David Gibson wrote: > pnv_cpu_init() is only called from the the pnv cpu core realize path, and > really only can be called from there. So fold it into its caller, which > we also rename for brevity. > > Signed-off-by: David Gibson I think we should set the default CPU s

[Qemu-devel] [PATCH 4/7] pnv: Clean up cpu realize path

2018-06-12 Thread David Gibson
pnv_cpu_init() is only called from the the pnv cpu core realize path, and really only can be called from there. So fold it into its caller, which we also rename for brevity. Signed-off-by: David Gibson --- hw/ppc/pnv_core.c | 56 ++- 1 file changed, 2