Re: [Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-27 Thread Markus Armbruster
John Snow writes: > On the subject of compatibly broken: > Is there any circumstance where the mapping has *any* effect on the > current working behavior? Since we do not support the shorthand syntax > at all currently, there is no code that USES this mapping to do > anything. > > Even if you spe

Re: [Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-26 Thread John Snow
On 09/25/2014 02:13 AM, Markus Armbruster wrote: John Snow writes: On 09/24/2014 10:35 AM, Markus Armbruster wrote: John Snow writes: Instead of duplicating the logic for the if_ide (bus,unit) mappings, rely on the blockdev layer for managing those mappings for us, and use the drive_get_

Re: [Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-24 Thread Markus Armbruster
John Snow writes: > On 09/24/2014 10:35 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Instead of duplicating the logic for the if_ide >>> (bus,unit) mappings, rely on the blockdev layer >>> for managing those mappings for us, and use the >>> drive_get_by_index call instead. >>> >>> Th

Re: [Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-24 Thread John Snow
On 09/24/2014 10:35 AM, Markus Armbruster wrote: John Snow writes: Instead of duplicating the logic for the if_ide (bus,unit) mappings, rely on the blockdev layer for managing those mappings for us, and use the drive_get_by_index call instead. This allows ide_drive_get to work for AHCI HBAs

Re: [Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-24 Thread Markus Armbruster
John Snow writes: > Instead of duplicating the logic for the if_ide > (bus,unit) mappings, rely on the blockdev layer > for managing those mappings for us, and use the > drive_get_by_index call instead. > > This allows ide_drive_get to work for AHCI HBAs > as well, and can be used in the Q35 init

[Qemu-devel] [PATCH 4/6] ide: Update ide_drive_get to be HBA agnostic

2014-09-23 Thread John Snow
Instead of duplicating the logic for the if_ide (bus,unit) mappings, rely on the blockdev layer for managing those mappings for us, and use the drive_get_by_index call instead. This allows ide_drive_get to work for AHCI HBAs as well, and can be used in the Q35 initialization. Signed-off-by: John