Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions

2016-08-18 Thread Cao jin
On 08/18/2016 01:23 PM, Dmitry Fleytman wrote: On 17 Aug 2016, at 17:39, Cao jin wrote: Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix() is unnecessary, remove them all. Is there any reason to drop these functions? They exist to improve code readability and modularisat

Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions

2016-08-17 Thread Dmitry Fleytman
> On 17 Aug 2016, at 17:39, Cao jin wrote: > > Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix() > is unnecessary, remove them all. Is there any reason to drop these functions? They exist to improve code readability and modularisation. > MSI-X state flag is used by intr_stat

[Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions

2016-08-17 Thread Cao jin
Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix() is unnecessary, remove them all. MSI-X state flag is used by intr_state which exists in vmstate, keep it for migration compatibility. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S.