Re: [Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-14 Thread Sven Schnelle
Hi Richard, On Mon, Feb 11, 2019 at 08:27:32PM -0800, Richard Henderson wrote: > On 2/11/19 10:19 AM, Sven Schnelle wrote: > > -f = (orig & 4) / 4; > > - > > -return do_log_cond(c * 2 + f, res); > > Given that this used to reference do_log_cond, and you've fixed do_log_cond, > why is the

Re: [Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > -f = (orig & 4) / 4; > - > -return do_log_cond(c * 2 + f, res); Given that this used to reference do_log_cond, and you've fixed do_log_cond, why is there any reason for a change here? r~

[Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-11 Thread Sven Schnelle
Now that do_cond() uses sign overflow for some condition matches we need to roll our own version without sign overflow checks. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/target/