Re: [Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

2018-03-20 Thread Paolo Bonzini
On 21/03/2018 01:35, John Snow wrote: >> The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the >> AHCI case ide_set_irq was actually called at the end of a mutual recursion. >> Move it early, with the side effect that ide_transfer_start becomes a tail >> call in ide_atapi_cmd_repl

Re: [Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

2018-03-20 Thread John Snow
On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the > AHCI case ide_set_irq was actually called at the end of a mutual recursion. > Move it early, with the side effect that ide_transfer_start becomes a tail > call in ide_atapi_cmd

[Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

2018-02-23 Thread Paolo Bonzini
The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the AHCI case ide_set_irq was actually called at the end of a mutual recursion. Move it early, with the side effect that ide_transfer_start becomes a tail call in ide_atapi_cmd_reply_end. Signed-off-by: Paolo Bonzini --- hw/ide/