Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 10:22:17 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 08:16:17AM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 13:46:50 +0800 > > Jason Wang wrote: > > > > > This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. > > > > > > This is because: > >

Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-13 Thread Jason Wang
On 07/13/2015 02:16 PM, Cornelia Huck wrote: > On Mon, 13 Jul 2015 13:46:50 +0800 > Jason Wang wrote: > >> This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. >> >> This is because: >> - vhost support virtio 1.0 now >> - transport code (e.g virtio-pci) set this feature when modern is >

Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 08:16:17AM +0200, Cornelia Huck wrote: > On Mon, 13 Jul 2015 13:46:50 +0800 > Jason Wang wrote: > > > This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. > > > > This is because: > > - vhost support virtio 1.0 now > > - transport code (e.g virtio-pci) set this f

Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-12 Thread Cornelia Huck
On Mon, 13 Jul 2015 13:46:50 +0800 Jason Wang wrote: > This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. > > This is because: > - vhost support virtio 1.0 now > - transport code (e.g virtio-pci) set this feature when modern is > enabled, setting this unconditionally will break disa

[Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-12 Thread Jason Wang
This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. This is because: - vhost support virtio 1.0 now - transport code (e.g virtio-pci) set this feature when modern is enabled, setting this unconditionally will break disable-modern=on. Cc: Cornelia Huck Signed-off-by: Jason Wang ---