Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:37:02AM +0100, Stefano Stabellini wrote: > On Wed, 16 May 2012, Michael S. Tsirkin wrote: > > On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > > > On Wed, 16 May 2012, Paolo Bonzini wrote: > > > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: >

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Stefano Stabellini
On Wed, 16 May 2012, Michael S. Tsirkin wrote: > On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > > On Wed, 16 May 2012, Paolo Bonzini wrote: > > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > > > >

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > On Wed, 16 May 2012, Paolo Bonzini wrote: > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > > >> On Xen the PV drivers can ask the firmware to surprise-

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Stefano Stabellini
On Wed, 16 May 2012, Paolo Bonzini wrote: > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > >> On Xen the PV drivers can ask the firmware to surprise-remove the > >> emulated NICs. > > > > So driver tells firmware (meaning ac

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: >> On Xen the PV drivers can ask the firmware to surprise-remove the >> emulated NICs. > > So driver tells firmware (meaning acpi? how?) that it's ok > to do surprize removal? It w

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > Il 15/05/2012 23:00, Michael S. Tsirkin ha scritto: > > On Tue, May 15, 2012 at 04:26:39PM +0100, Anthony PERARD wrote: > >> In the context of PV-on-HVM under Xen, the emulated nics are supposed to be > >> unplug before the guest driv

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Paolo Bonzini
Il 15/05/2012 23:00, Michael S. Tsirkin ha scritto: > On Tue, May 15, 2012 at 04:26:39PM +0100, Anthony PERARD wrote: >> In the context of PV-on-HVM under Xen, the emulated nics are supposed to be >> unplug before the guest drivers are initialized. This mean that there must be >> unplug without the

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-15 Thread Michael S. Tsirkin
On Tue, May 15, 2012 at 04:26:39PM +0100, Anthony PERARD wrote: > In the context of PV-on-HVM under Xen, the emulated nics are supposed to be > unplug before the guest drivers are initialized. This mean that there must be > unplug without the consent of the guest. > > Without this patch, the guest

[Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-15 Thread Anthony PERARD
In the context of PV-on-HVM under Xen, the emulated nics are supposed to be unplug before the guest drivers are initialized. This mean that there must be unplug without the consent of the guest. Without this patch, the guest end up with two nics with the same MAC, the emulated nic and the PV nic.