Re: [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-06-03 Thread Richard Henderson
On 06/03/2013 04:21 AM, Jani Kokkonen wrote: >> @ merge the tlb index into the env+tlb_offset >> add x1, x1, x0, lsl #3 For the record, oops. 3 should be CPU_TLB_ENTRY_BITS. r~

Re: [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-06-03 Thread Jani Kokkonen
On 5/31/2013 10:25 PM, Richard Henderson wrote: > On 05/31/2013 11:07 AM, Jani Kokkonen wrote: >> +/* Load and compare a TLB entry, leaving the flags set. Leaves X2 pointing >> + to the tlb entry. Clobbers X0,X1,X2,X3 and TMP. */ >> + >> +static void tcg_out_tlb_read(TCGContext *s, TCGReg addr

[Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-05-31 Thread Jani Kokkonen
From: Jani Kokkonen implement the fast path for tcg_out_qemu_ld/st. Signed-off-by: Jani Kokkonen --- tcg/aarch64/tcg-target.c | 161 +-- 1 file changed, 157 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target

Re: [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-05-31 Thread Richard Henderson
On 05/31/2013 11:07 AM, Jani Kokkonen wrote: > +/* Load and compare a TLB entry, leaving the flags set. Leaves X2 pointing > + to the tlb entry. Clobbers X0,X1,X2,X3 and TMP. */ > + > +static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, > + int s_bits, uint