Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Jes Sorensen
On 01/25/11 11:17, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 01/24/11 18:47, Markus Armbruster wrote: >>> Jes Sorensen writes: >>> qemu_toupper() - whats the problem? > If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case > will not match any input. >>>

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Markus Armbruster
Jes Sorensen writes: > On 01/24/11 18:47, Markus Armbruster wrote: >> Jes Sorensen writes: >> qemu_toupper() - whats the problem? If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case will not match any input. >>> >>> Right, so one has to be careful when adding new

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Jes Sorensen
On 01/24/11 18:47, Markus Armbruster wrote: > Jes Sorensen writes: > qemu_toupper() - whats the problem? >>> If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case >>> will not match any input. >> >> Right, so one has to be careful when adding new suffix constants. > > Calls fo

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Markus Armbruster
Jes Sorensen writes: > On 01/24/11 17:39, Markus Armbruster wrote: > +case STRTOSZ_DEFSUFFIX_TB: > >>> mul = 1ULL << 40; > >>> break; > >>> default: >> >> Phony abstraction. And it leaks: code here assumes the >> STRTOSZ_DEFSUFFIX_T* are

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Jes Sorensen
On 01/24/11 17:39, Markus Armbruster wrote: +case STRTOSZ_DEFSUFFIX_TB: >>> mul = 1ULL << 40; >>> break; >>> default: >>> >> >>> >> Phony abstraction. And it leaks: code here assumes the >>> >> STRTOSZ_DEFSUFFIX_T* are all upper case. >> > >> > qemu_

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Markus Armbruster
Jes Sorensen writes: > On 01/24/11 17:08, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >> >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >>> --- >>> cutils.c | 10 +- >>> 1 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/cutils.c b/cuti

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > cutils.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/cutils.c b/cutils.c > index 369a016..8d562b2 100644 > --- a/cutils.c > +++ b/cutils.c > @@ -324,26 +324,26

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Jes Sorensen
On 01/24/11 17:08, Markus Armbruster wrote: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> cutils.c | 10 +- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/cutils.c b/cutils.c >> index 369a016..8d562b2 1006

[Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-24 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 369a016..8d562b2 100644 --- a/cutils.c +++ b/cutils.c @@ -324,26 +324,26 @@ int64_t strtosz_suffix(const char *nptr, char **end