[Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-18 Thread Michael S. Tsirkin
This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output: mmio-no-eventfd:pci-mem 8796 mmio-wildcard-eventfd:pci-mem 3609 mmio-datamatch-eventfd:pci-mem 3685 portio-no-eventfd

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
- Messaggio originale - > Da: "Michael S. Tsirkin" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, g...@redhat.com, > mtosa...@redhat.com > Inviato: Mercoledì, 3 aprile 2013 20:39:58 > Oggetto: Re: [PATCH 4/4] pci: add pci test device > > On Wed, Apr 03, 2013 a

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 05:43:40PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 17:09, Michael S. Tsirkin ha scritto: > > Okay after some more thought. > > hw/pci-host/ > > hw/pci-bridge/ > > hw/isa-bridge/ > > Renaming hw/isa to hw/isa-bridge is easy. > > For the rest, I would prefer hw/pci/{core

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 19:04, Michael S. Tsirkin ha scritto: > Well ATM it's part of libhw and is built twice. Not sure what > do you propose here. Things haven't been built twice for a few months. hwaddr is unconditionally 64-bit wide. Paolo

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 05:46:00PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 16:28, Michael S. Tsirkin ha scritto: > > > You need to group similar devices for the nesting to be useful. For > > > example, it should be easy to check if something is true of all ISA > > > bridges, or to do the same

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 16:28, Michael S. Tsirkin ha scritto: > > You need to group similar devices for the nesting to be useful. For > > example, it should be easy to check if something is true of all ISA > > bridges, or to do the same change in all of them. ISA and PCI bridges > > have too little in comm

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 17:09, Michael S. Tsirkin ha scritto: > Okay after some more thought. > hw/pci-host/ > hw/pci-bridge/ > hw/isa-bridge/ Renaming hw/isa to hw/isa-bridge is easy. For the rest, I would prefer hw/pci/{core,host,bridge}, but whatever you like the most is fine for me too. Paolo

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 04:08:45PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > > devices. > > > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > > a

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 04:08:45PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > > devices. > > > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > > a

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 04:08:45PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > > devices. > > > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > > a

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > devices. > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > as well then. You need to group similar devices for the nesting to be usefu

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 02:05:32PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 14:00, Michael S. Tsirkin ha scritto: > > On Wed, Apr 03, 2013 at 01:48:41PM +0200, Paolo Bonzini wrote: > >> Il 03/04/2013 12:38, Michael S. Tsirkin ha scritto: > >>> On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonz

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 14:00, Michael S. Tsirkin ha scritto: > On Wed, Apr 03, 2013 at 01:48:41PM +0200, Paolo Bonzini wrote: >> Il 03/04/2013 12:38, Michael S. Tsirkin ha scritto: >>> On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: >>>

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 01:48:41PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:38, Michael S. Tsirkin ha scritto: > > On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: > >> Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: > Because someone wasn't looking. :) The hw/ reorgan

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:38, Michael S. Tsirkin ha scritto: > On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: >> Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: Because someone wasn't looking. :) The hw/ reorganization patches I've posted fix that. >>> >>> Still not sure how t

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 12:25:02PM +0200, Paolo Bonzini wrote: > > > Exactly. I prefer a flexible structure so I can change > > things host side. For example register multiple > > datamatches with same address and compare speed > > of access on first and last one. > > Similarly for address. > > O

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: > > Because someone wasn't looking. :) The hw/ reorganization patches I've > > posted fix that. > > Still not sure how to merge this, if it goes in through my tree > and that's the only comment, I'll just fix it silently ... Indeed. In fact, c

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: > > > Because someone wasn't looking. :) The hw/ reorganization patches I've > > > posted fix that. > > > > Still not sure how to merge this, if it goes in through my tree > > and

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
> Exactly. I prefer a flexible structure so I can change > things host side. For example register multiple > datamatches with same address and compare speed > of access on first and last one. > Similarly for address. Ok, this makes sense. >> (BTW, and unrelated to this, please use default-config

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:53:59AM +0200, Paolo Bonzini wrote: > Il 03/04/2013 11:45, Michael S. Tsirkin ha scritto: > > On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: > >> Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: > >>> This device is used for kvm unit tests, > >>> curren

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 11:45, Michael S. Tsirkin ha scritto: > On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: >> Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: >>> This device is used for kvm unit tests, >>> currently it supports testing performance of ioeventfd. >>> Using updated kvm u

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: > Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: > > This device is used for kvm unit tests, > > currently it supports testing performance of ioeventfd. > > Using updated kvm unittest, here's an example output: > > mmio-no-

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: > This device is used for kvm unit tests, > currently it supports testing performance of ioeventfd. > Using updated kvm unittest, here's an example output: > mmio-no-eventfd:pci-mem 8796 > mmio-wildcard-eventfd:pci-mem 3609 >

[Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output: mmio-no-eventfd:pci-mem 8796 mmio-wildcard-eventfd:pci-mem 3609 mmio-datamatch-eventfd:pci-mem 3685 portio-no-eventfd