Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-05 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 10:00:41AM +0800, zhanghailiang wrote: > Hi Michael, > Thanks for your review of this patch! > > >On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: > >>The function fstat() may fail, so check its return value. > >> > >>Signed-off-by: zhanghailiang > >>--- > >>

Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-05 Thread zhanghailiang
On 2014/8/5 14:50, Levente Kurusa wrote: - Original Message - Hi Michael, Thanks for your review of this patch! On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang --- hw/misc/ivshmem

Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-04 Thread Levente Kurusa
- Original Message - > Hi Michael, > Thanks for your review of this patch! > > > On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: > >> The function fstat() may fail, so check its return value. > >> > >> Signed-off-by: zhanghailiang > >> --- > >> hw/misc/ivshmem.c | 5 -

Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-04 Thread zhanghailiang
Hi Michael, Thanks for your review of this patch! On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang --- hw/misc/ivshmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-04 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: > The function fstat() may fail, so check its return value. > > Signed-off-by: zhanghailiang > --- > hw/misc/ivshmem.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.

[Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-04 Thread zhanghailiang
The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang --- hw/misc/ivshmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 768e528..2667e9f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c