Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

2015-05-28 Thread Michael Tokarev
28.05.2015 15:19, Mark Cave-Ayland wrote: [] > The FCode ROMs supplied for CG3/TCX are used to both initialise various > DT entries for the graphic adapters and also provide a minimal driver to > allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot. > > I'd say at the moment the

Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

2015-05-28 Thread Mark Cave-Ayland
On 28/05/15 13:01, Michael Tokarev wrote: > 28.05.2015 14:54, Michael Tokarev wrote: >> Applied to -trivial, thanks! > > ..or not applied yet... :) > > This is again the same situation with the error message as with > 1/4 hw/display/cg3.c, and the same question - is the error fatal? > > And not

Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

2015-05-28 Thread Michael Tokarev
28.05.2015 14:54, Michael Tokarev wrote: > Applied to -trivial, thanks! ..or not applied yet... :) This is again the same situation with the error message as with 1/4 hw/display/cg3.c, and the same question - is the error fatal? And note that you're the number-one person who made changes to this

Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

2015-05-28 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind

2015-05-28 Thread Shannon Zhao
From: Shannon Zhao valgrind complains about: ==23693== 55 bytes in 1 blocks are definitely lost in loss record 1,277 of 2,014 ==23693==at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==23693==by 0x21B93F: malloc_and_trace (vl.c:2556) ==23693==by 0x64C7