Re: [Qemu-devel] [PATCH 4/4] block: drop bs->job

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:58, Kevin Wolf wrote: > Am 06.06.2019 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Drop remaining users of bs->job: >> 1. assertions actually duplicated by assert(!bs->refcnt) >> 2. trace-point seems not enough reason to change stream_start to return >> BlockJob point

Re: [Qemu-devel] [PATCH 4/4] block: drop bs->job

2019-06-17 Thread Kevin Wolf
Am 06.06.2019 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > Drop remaining users of bs->job: > 1. assertions actually duplicated by assert(!bs->refcnt) > 2. trace-point seems not enough reason to change stream_start to return >BlockJob pointer > 3. Restricting creation of two jobs ba

[Qemu-devel] [PATCH 4/4] block: drop bs->job

2019-06-06 Thread Vladimir Sementsov-Ogievskiy
Drop remaining users of bs->job: 1. assertions actually duplicated by assert(!bs->refcnt) 2. trace-point seems not enough reason to change stream_start to return BlockJob pointer 3. Restricting creation of two jobs based on same bs is bad idea, as 3.1 Some jobs creates filters to be their mai