Re: [Qemu-devel] [PATCH 4/4] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-09-27 Thread Vladimir Sementsov-Ogievskiy
27.09.2019 0:44, John Snow wrote: > > > On 9/26/19 3:28 PM, Eric Blake wrote: >> On 9/26/19 1:54 PM, John Snow wrote: >>> >>> >>> On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_dirty_bitmap_next is always used in same pattern. So, split it into _next and _first, instead o

Re: [Qemu-devel] [PATCH 4/4] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-09-26 Thread John Snow
On 9/26/19 3:28 PM, Eric Blake wrote: > On 9/26/19 1:54 PM, John Snow wrote: >> >> >> On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: >>> bdrv_dirty_bitmap_next is always used in same pattern. So, split it >>> into _next and _first, instead of combining two functions into one and >>> ad

Re: [Qemu-devel] [PATCH 4/4] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-09-26 Thread Eric Blake
On 9/26/19 1:54 PM, John Snow wrote: On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_dirty_bitmap_next is always used in same pattern. So, split it into _next and _first, instead of combining two functions into one and add FOR_EACH_DIRTY_BITMAP macro. Signed-off-by: Vladimir Sem

Re: [Qemu-devel] [PATCH 4/4] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-09-26 Thread John Snow
On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_dirty_bitmap_next is always used in same pattern. So, split it > into _next and _first, instead of combining two functions into one and > add FOR_EACH_DIRTY_BITMAP macro. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > in

[Qemu-devel] [PATCH 4/4] block/dirty-bitmap: refactor bdrv_dirty_bitmap_next

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
bdrv_dirty_bitmap_next is always used in same pattern. So, split it into _next and _first, instead of combining two functions into one and add FOR_EACH_DIRTY_BITMAP macro. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 9 +++-- block.c