Re: [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler

2011-08-17 Thread Richard Henderson
On 08/16/2011 11:52 PM, Khansa Butt wrote: > If I pass env->insn_flags to target_disas() how can I pass this flag info > from disas.c to mips-dis.c. can i do following thing for MIPS in disas.c > if (flags & 0x) { > disasm_info.mach = flags & 0x; Well, I'd have written this as

Re: [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler

2011-08-16 Thread Khansa Butt
On Mon, Aug 15, 2011 at 9:37 PM, Richard Henderson wrote: > On 08/15/2011 04:25 AM, kha...@kics.edu.pk wrote: > > index 1334b8e..0137657 100644 > > --- a/disas.c > > +++ b/disas.c > > @@ -140,6 +140,7 @@ print_insn_thumb1(bfd_vma pc, disassemble_info *info) > > i386 - nonzero means 16 bit co

Re: [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler

2011-08-15 Thread Richard Henderson
On 08/15/2011 04:25 AM, kha...@kics.edu.pk wrote: > index 1334b8e..0137657 100644 > --- a/disas.c > +++ b/disas.c > @@ -140,6 +140,7 @@ print_insn_thumb1(bfd_vma pc, disassemble_info *info) > i386 - nonzero means 16 bit code > arm - nonzero means thumb code > ppc - nonzero means li

[Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler

2011-08-15 Thread khansa
From: Khansa Butt Signed-off-by: Khansa Butt --- disas.c |4 +++ mips-dis.c | 61 +++ target-mips/translate.c |3 ++ 3 files changed, 68 insertions(+), 0 deletions(-) diff --git a/disas.c b/disas.c index 1334b8